RFR: 8199736: Define WIN32_LEAN_AND_MEAN before including windows.h

[Robin Westberg]

Hi Magnus,

Thanks for the review!

Best regards,
Robin

> On 23 Mar 2018, at 16:43, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
> 
> This looks good to me.
> 
> /Magnus
> 
>> 23 mars 2018 kl. 14:58 skrev Erik Joelsson <erik.joelsson at oracle.com>:
>> 
>> I think this looks good, but Magnus is currently refactoring the flags handling in configure so better get his input as well. (adding build-dev)
>> 
>> /Erik
>> 
>> 
>>> On 2018-03-23 05:37, Robin Westberg wrote:
>>> Hi Kim & Erik,
>>> 
>>> Certainly makes sense to define it from the build system, I’ve updated the patch accordingly:
>>> 
>>> Full: http://cr.openjdk.java.net/~rwestberg/8199736/webrev.01/ <http://cr.openjdk.java.net/%7Erwestberg/8199736/webrev.01/>
>>> Incremental: http://cr.openjdk.java.net/~rwestberg/8199736/webrev.00-01/ <http://cr.openjdk.java.net/%7Erwestberg/8199736/webrev.00-01/>
>>> 
>>> (Not quite sure if the definition belongs where I put it or a bit later where most other windows-specific JVM flags are defined, but seemed reasonable to put it close to where it is defined for the JDK libraries).
>>> 
>>> Best regards,
>>> Robin
>>> 
>>>>>> On 22 Mar 2018, at 16:52, Kim Barrett <kim.barrett at oracle.com <mailto:kim.barrett at oracle.com>> wrote:
>>>>> 
>>>>> On Mar 22, 2018, at 10:34 AM, Robin Westberg <robin.westberg at oracle.com <mailto:robin.westberg at oracle.com>> wrote:
>>>>> 
>>>>> Hi all,
>>>>> 
>>>>> Please review the following change that defines WIN32_LEAN_AND_MEAN [1] before including windows.h. This marginally improves build times, and makes it possible to include winsock2.h.
>>>>> 
>>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8199736 <https://bugs.openjdk.java.net/browse/JDK-8199736>
>>>>> Webrev: http://cr.openjdk.java.net/~rwestberg/8199736/webrev.00/ <http://cr.openjdk.java.net/%7Erwestberg/8199736/webrev.00/> <http://cr.openjdk.java.net/~rwestberg/8199736/webrev.00/ <http://cr.openjdk.java.net/%7Erwestberg/8199736/webrev.00/>>
>>>>> Testing: hs-tier1
>>>>> 
>>>>> Best regards,
>>>>> Robin
>>>>> 
>>>>> [1] https://msdn.microsoft.com/en-us/library/windows/desktop/aa383745%28v=vs.85%29.aspx#faster_builds_with_smaller_header_files <https://msdn.microsoft.com/en-us/library/windows/desktop/aa383745(v=vs.85).aspx#faster_builds_with_smaller_header_files <https://msdn.microsoft.com/en-us/library/windows/desktop/aa383745%28v=vs.85%29.aspx#faster_builds_with_smaller_header_files>>
>>>> 
>>>> I think the addition of the WIN32_LEAN_AND_MEAN definition should be done through the build
>>>> system, so that it applies everywhere.
>>>> 
>>> 
>> 
>