RFR: 8200232: Build failures after JDK-8200106 (Move NoSafepointVerifier out from gcLocker.hpp)

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Mon Mar 26 21:46:46 UTC 2018


I agree that it's a trivial change and I reviewed it too.
Thanks,
Coleen

On 3/26/18 4:46 PM, Thomas Stüfe wrote:
> On Mon 26. Mar 2018 at 22:40, Aleksey Shipilev <shade at redhat.com> wrote:
>
>> On 03/26/2018 09:13 PM, Thomas Stüfe wrote:
>>> We do not build windows 32bit anymore, at least not for openjdk11. That
>> was Martins private thing
>>> over the last weeks.
>>>
>>> We never did build ppc32 bit to my knowledge - this should be zero only,
>> no? Might be worth checking
>>> with Adrian, he builds zero regularly.
>>>
>>> Anyway, I had a quick look through the sources and it seems you should
>> fix os_solaris_x86.cpp and
>>> os_bsd_x86.cpp too, same error there. All the other os_xx_xx.cpp seem
>> fine to me.
>>
>> Right. I double checked all os_*.cpp things too. This is a new webrev:
>>    http://cr.openjdk.java.net/~shade/8200232/webrev.02/
>>
>> I shall run it through hs-submit to make sure.
>>
>> Thanks,
>> -Aleksey
>>
>>
> Change looks good and trivial.
>
> Thanks, Thomas



More information about the hotspot-dev mailing list