RFR (S,trivial) 8200276: Cleanup allocation.hpp includes
Stefan Karlsson
stefan.karlsson at oracle.com
Tue Mar 27 15:03:53 UTC 2018
On 2018-03-27 15:29, coleen.phillimore at oracle.com wrote:
>
>
> On 3/27/18 8:41 AM, coleen.phillimore at oracle.com wrote:
>>
>>
>> On 3/27/18 4:04 AM, Stefan Karlsson wrote:
>>> Hi Coleen,
>>>
>>> This file is using CHeapObj and StackObj, and should keep including
>>> allocation.hpp.
>>>
>>> http://cr.openjdk.java.net/~coleenp/8200276.01/webrev/src/hotspot/share/gc/parallel/psVirtualspace.hpp.frames.html
>>>
>>
>> Yes, that's why I added allocation.hpp to this one.
>>>
>>> These files are using MetaspaceObj:
>>>
>>> http://cr.openjdk.java.net/~coleenp/8200276.01/webrev/src/hotspot/share/oops/cpCache.hpp.frames.html
>>>
>>>
>>> http://cr.openjdk.java.net/~coleenp/8200276.01/webrev/src/hotspot/share/oops/array.hpp.frames.html
>>>
>>>
>>> This file is using ReallocMark:
>>> http://cr.openjdk.java.net/~coleenp/8200276.01/webrev/src/hotspot/share/code/exceptionHandlerTable.hpp.frames.html
>>>
>>
>> My script didn't look for these. I added them back.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8200276.02/webrev
>
> The incremental is that I reverted cpCache.hpp, array.hpp and
> exceptionHandlerTable.hpp changes, so they're not present in the new
> webrev.
Sounds good.
StefanK
>
> Thanks,
> Coleen
>
>>
>> And checked the rest.
>>
>> thanks,
>> Coleen
>>
>> Thanks,
>> Coleen
>>>
>>> Thanks,
>>> StefanK
>>>
>>> On 2018-03-27 01:56, coleen.phillimore at oracle.com wrote:
>>>> These includes are no longer needed with VALUE_OBJ_CLASS_SPEC
>>>> removed in these files.
>>>>
>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8200276.01/webrev
>>>> bug link https://bugs.openjdk.java.net/browse/JDK-8200276
>>>>
>>>> Tested tier1 on oracle platforms: linux-x64, solaris-sparc,
>>>> macos-x86, windows-x86. Tested open-only with
>>>> --disable-precompiled-headers. Built zero on linux x64.
>>>>
>>>> Thanks,
>>>> Coleen
>>
>
More information about the hotspot-dev
mailing list