RFR: 8199619: Building HotSpot on Windows should define NOMINMAX
Robin Westberg
robin.westberg at oracle.com
Wed Mar 28 13:43:07 UTC 2018
Hi Erik,
Thanks for reviewing!
Best regards,
Robin
> On 26 Mar 2018, at 17:50, Erik Joelsson <erik.joelsson at oracle.com> wrote:
>
> Looks good.
>
> /Erik
>
>
> On 2018-03-26 08:01, Robin Westberg wrote:
>> Hi all,
>>
>> Please review this small change that defines the NOMINMAX macro when building HotSpot on Windows.
>>
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8199619
>> Webrev: http://cr.openjdk.java.net/~rwestberg/8199619/webrev.00/ <http://cr.openjdk.java.net/~rwestberg/8199619/webrev.00/>
>> Testing: building with/without precompiled headers, hs-tier1
>>
>> Best regards,
>> Robin
>
More information about the hotspot-dev
mailing list