RFR(XS): 8200360: MeetIncompatibleInterfaceArrays fails with "MeetIncompatibleInterfaceArrays0ASM.run() must be compiled at tier 0 !"

[Vladimir Kozlov]

Okay.

Thanks,
Vladimir

On 3/28/18 7:49 AM, Volker Simonis wrote:
> Hi,
> can I please have a review for the following tiny test fix:
> 
> http://cr.openjdk.java.net/~simonis/webrevs/2018/8200360/
> https://bugs.openjdk.java.net/browse/JDK-8200360
> 
> With the fix for JDK-8198915 I changed the test
> TestMeetIncompatibleInterfaceArrays.java to more thoroughly verify if
> the test method has been really compiled on the requested compilation
> level. This works fine in general, but if the JTreg tests are run in
> special configurations like for example "-server
> -XX:-TieredCompilation", C1 compilations doesn't not work.
> 
> There are two possible solution for this problem: either relax the
> check for the correct compilation level or explicitly set
> "-XX:+TieredCompilation" in the "@run" action. The second variant is
> possible because the options passed in the "@run" action come AFTER
> the global JTreg options passed with with "-vmoptions" on the final
> command line and thus can override them.
> 
> I went for the second variant in this fix because the test in question
> actually wants to check the different compilation levels and it
> doesn't make sense in other configurations. Finally, I now also
> explicitly set "-XX:TieredStopAtLevel=4" just for the case you have
> other test configurations which limit the compilations levels.
> 
> It would be great if somebody could run this trough the "hs-tier2"
> test suite and any other relevant internal test suites because the
> problem doesn't show up in the tier1 tests.
> 
> I also won't be available any more today, so if this is urgent and
> your fine with the fix, please feel free to push it. Otherwise I'll do
> it tomorrow morning (CET).
> 
> Thank you and best regards,
> Volker
>