RFR 8200423: Non-PCH build for x86_32 fails

Roman Kennke rkennke at redhat.com
Thu Mar 29 10:49:16 UTC 2018


Am 29.03.2018 um 12:44 schrieb Aleksey Shipilev:
> Bug:
>   https://bugs.openjdk.java.net/browse/JDK-8200423
> 
> The fix is to add the same header sharedRuntime_x86_64.cpp uses:
> 
> 8200423: Non-PCH build for x86_32 fails
> Reviewed-by: XXX
> 
> diff -r 2ad3212a7dd9 -r 663e1ccf9d4e src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp
> --- a/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp	Thu Mar 29 10:38:29 2018 +0200
> +++ b/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp	Thu Mar 29 12:43:52 2018 +0200
> @@ -27,6 +27,7 @@
>  #include "asm/macroAssembler.inline.hpp"
>  #include "code/debugInfoRec.hpp"
>  #include "code/icBuffer.hpp"
> +#include "code/nativeInst.hpp"
>  #include "code/vtableStubs.hpp"
>  #include "gc/shared/gcLocker.hpp"
>  #include "interpreter/interpreter.hpp"
> 
> 
> I think it falls under triviality rule.
> 
> Testing: x86_32 build

Sure, go for it



More information about the hotspot-dev mailing list