RFR 8200423: Non-PCH build for x86_32 fails

Aleksey Shipilev shade at redhat.com
Thu Mar 29 10:57:26 UTC 2018


Thanks guys, pushed.

-Aleksey

On 03/29/2018 12:50 PM, Thomas Stüfe wrote:
> Looks good.
> 
> ..Thomas
> 
> On Thu, Mar 29, 2018 at 12:44 PM, Aleksey Shipilev <shade at redhat.com <mailto:shade at redhat.com>> wrote:
> 
>     Bug:
>       https://bugs.openjdk.java.net/browse/JDK-8200423
>     <https://bugs.openjdk.java.net/browse/JDK-8200423>
> 
>     The fix is to add the same header sharedRuntime_x86_64.cpp uses:
> 
>     8200423: Non-PCH build for x86_32 fails
>     Reviewed-by: XXX
> 
>     diff -r 2ad3212a7dd9 -r 663e1ccf9d4e src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp
>     --- a/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp      Thu Mar 29 10:38:29 2018 +0200
>     +++ b/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp      Thu Mar 29 12:43:52 2018 +0200
>     @@ -27,6 +27,7 @@
>      #include "asm/macroAssembler.inline.hpp"
>      #include "code/debugInfoRec.hpp"
>      #include "code/icBuffer.hpp"
>     +#include "code/nativeInst.hpp"
>      #include "code/vtableStubs.hpp"
>      #include "gc/shared/gcLocker.hpp"
>      #include "interpreter/interpreter.hpp"
> 
> 
>     I think it falls under triviality rule.
> 
>     Testing: x86_32 build
> 
>     Thanks,
>     -Aleksey
> 
> 




More information about the hotspot-dev mailing list