RFR: 8200251: AArch64::CPUFeature out of sync with VM_Version::Feature_Flag

Aleksey Shipilev shade at redhat.com
Thu Mar 29 16:37:57 UTC 2018


On 03/29/2018 06:28 PM, Andrew Haley wrote:
> On 03/29/2018 03:48 PM, stewartd.qdt wrote:
>> Could I get another review and a sponsor for this?
> 
> You don't need another reviewer for this.  It can be pushed.

I can sponsor this, note the Contributed-by line:

8200251: AArch64::CPUFeature out of sync with VM_Version::Feature_Flag
Reviewed-by: kvn, aph, shade
Contributed-by: Daniel Stewart <stewartd.qdt at qualcommdatacenter.com>

diff -r 5a757c0326c7 -r 940ab7917a49
src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.aarch64/src/jdk/vm/ci/aarch64/AArch64.java
--- a/src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.aarch64/src/jdk/vm/ci/aarch64/AArch64.java	Thu
Mar 29 17:15:26 2018 +0200
+++ b/src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.aarch64/src/jdk/vm/ci/aarch64/AArch64.java	Thu
Mar 29 18:35:13 2018 +0200
@@ -171,6 +171,8 @@
         SHA1,
         SHA2,
         CRC32,
+        LSE,
+        STXR_PREFETCH,
         A53MAC,
         DMB_ATOMICS
     }
@@ -183,7 +185,11 @@
     public enum Flag {
         UseBarriersForVolatile,
         UseCRC32,
-        UseNeon
+        UseNeon,
+        UseSIMDForMemoryOps,
+        AvoidUnalignedAccesses,
+        UseLSE,
+        UseBlockZeroing
     }

     private final EnumSet<Flag> flags;


Thanks,
-Aleksey



More information about the hotspot-dev mailing list