RFR/RFC: Non-PCH x86_32 build failure: err_msg is not defined

Zhengyu Gu zgu at redhat.com
Thu Mar 29 17:01:22 UTC 2018


Ah, Thomas is right! Should not see x84_64 in 32 build.

-Zhengyu

On 03/29/2018 12:54 PM, Zhengyu Gu wrote:
> Looks good.
> 
> -Zhengyu
> 
> On 03/29/2018 12:21 PM, Aleksey Shipilev wrote:
>> Bug:
>>   https://bugs.openjdk.java.net/browse/JDK-8200438
>>
>> Obvious fix:
>>
>> diff -r 5a757c0326c7 src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp
>> --- a/src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp    Thu Mar 29 
>> 17:15:26 2018 +0200
>> +++ b/src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp    Thu Mar 29 
>> 18:17:58 2018 +0200
>> @@ -41,6 +41,7 @@
>>   #include "runtime/sharedRuntime.hpp"
>>   #include "runtime/vframeArray.hpp"
>>   #include "utilities/align.hpp"
>> +#include "utilities/formatBuffer.hpp"
>>   #include "vm_version_x86.hpp"
>>   #include "vmreg_x86.inline.hpp"
>>   #ifdef COMPILER1
>>
>>
>> The non-obvious part (and thus, "RFC") is why x86_64 build works fine 
>> in the same config. I don't
>> have the answer for that.
>>
>> Testing: x86_32 build
>>
>> Thanks,
>> -Aleksey
>>


More information about the hotspot-dev mailing list