RFR/RFC 8200438: Non-PCH x86_32 build failure: err_msg is not defined

[Thomas Stüfe]

I did not even know this was possible. I still keep a 32bit Ubuntu vm
around just to build 32bit. Will try this sometime (well, when it is fixed
:)

..Thomas

On Thu, Mar 29, 2018 at 7:46 PM, Aleksey Shipilev <shade at redhat.com> wrote:

> Submitted:
>   https://bugs.openjdk.java.net/browse/JDK-8200441
>
> -Aleksey
>
> On 03/29/2018 07:04 PM, Aleksey Shipilev wrote:
> > Me too! Still trying to figure how did that happen. Probably a bug in
> cross-build?
> >
> > -Aleksey
> >
> > On 03/29/2018 06:33 PM, Thomas Stüfe wrote:
> >> I am more confused that your 32bit build pulls sharedRuntime_x86_64.cpp
> ..
> >>
> >> Thomas
> >>
> >> On Thu, Mar 29, 2018 at 6:30 PM, Aleksey Shipilev <shade at redhat.com
> <mailto:shade at redhat.com>> wrote:
> >>
> >>     (correct subject, referencing bug id)
> >>
> >>     Maybe one of the reasons is that x86_32 is the cross-compiled
> build, but x86_64 is native, and this
> >>     is why x86_32 fails, when x86_64 is not.
> >>
> >>     -Aleksey
> >>
> >>     On 03/29/2018 06:21 PM, Aleksey Shipilev wrote:
> >>     > Bug:
> >>     >  https://bugs.openjdk.java.net/browse/JDK-8200438
> >>     <https://bugs.openjdk.java.net/browse/JDK-8200438>
> >>     >
> >>     > Obvious fix:
> >>     >
> >>     > diff -r 5a757c0326c7 src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp
> >>     > --- a/src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp    Thu Mar 29
> 17:15:26 2018 +0200
> >>     > +++ b/src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp    Thu Mar 29
> 18:17:58 2018 +0200
> >>     > @@ -41,6 +41,7 @@
> >>     >  #include "runtime/sharedRuntime.hpp"
> >>     >  #include "runtime/vframeArray.hpp"
> >>     >  #include "utilities/align.hpp"
> >>     > +#include "utilities/formatBuffer.hpp"
> >>     >  #include "vm_version_x86.hpp"
> >>     >  #include "vmreg_x86.inline.hpp"
> >>     >  #ifdef COMPILER1
> >>     >
> >>     >
> >>     > The non-obvious part (and thus, "RFC") is why x86_64 build works
> fine in the same config. I don't
> >>     > have the answer for that.
> >>     >
> >>     > Testing: x86_32 build
> >>     >
> >>     > Thanks,
> >>     > -Aleksey
> >>     >
> >>
> >>
> >>
> >
> >
>
>
>