RFR: 8200524 - AArch64: CPUFeature and Flag enums are not passed through JVMCI

stewartd.qdt stewartd.qdt at qualcommdatacenter.com
Fri Mar 30 17:48:28 UTC 2018


Might I get a sponsor for this change?

http://cr.openjdk.java.net/~dstewart/8200524/webrev.01/

Thank you,
Daniel

-----Original Message-----
From: stewartd.qdt 
Sent: Friday, March 30, 2018 12:12 PM
To: Vladimir Kozlov <vladimir.kozlov at oracle.com>; stewartd.qdt <stewartd.qdt at qualcommdatacenter.com>; hotspot-dev at openjdk.java.net
Subject: RE: RFR: 8200524 - AArch64: CPUFeature and Flag enums are not passed through JVMCI

Thanks, Vladimir.

-----Original Message-----
From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com] 
Sent: Friday, March 30, 2018 12:10 PM
To: stewartd.qdt <stewartd.qdt at qualcommdatacenter.com>; hotspot-dev at openjdk.java.net
Subject: Re: RFR: 8200524 - AArch64: CPUFeature and Flag enums are not passed through JVMCI

Changes looks good to me. They follow the same code pattern as on other architectures.

Thanks,
Vladimir

On 3/30/18 8:35 AM, stewartd.qdt wrote:
> Please review this webrev [1] which implements the transfer of AArch64::CPUFeature flags and AArch64::Flag enums over the JVMCI interface.
> 
> This patch sets the CPUFeature enums corresponding to which VM_Version flags are set. It also sets the Flag enums corresponding to which use flags have been set on the command line. This mirrors what is done for AMD64.
> 
> The bug report is filed at [2].
> 
> I am happy to modify the patch as necessary.
> 
> Regards,
> Daniel Stewart
> 
> [1] - http://cr.openjdk.java.net/~dstewart/8200524/webrev.00/
> [2] - https://bugs.openjdk.java.net/browse/JDK-8200524
> 


More information about the hotspot-dev mailing list