[8u] RFR(XS): 8202600: [Zero] Undefined behaviour in src/os_cpu/linux_zero/vm/os_linux_zero.cpp

David Holmes david.holmes at oracle.com
Fri May 4 08:29:42 UTC 2018


Reviewed.

Cheers,
David

On 4/05/2018 6:26 PM, Severin Gehwolf wrote:
> Hi,
> 
> On Thu, 2018-05-03 at 19:56 +0000, Thomas Stüfe wrote:
>> Hi Severin,
>>
>> Looks fine and trivial.
> 
> Thanks for the review!
> 
> Could I get another review from an JDK 8 Updates Project Reviewer,
> please?
> 
> Thanks,
> Severin
> 
>> Best regards, Thomas
>>
>> On Thu 3. May 2018 at 19:15, Severin Gehwolf <sgehwolf at redhat.com> wrote:
>>> Hi,
>>>
>>> Please review this trivial change which fixes a potential crasher bug
>>> in JDK 8 Zero. JDK 10+ don't have this problem since they got fixed
>>> with  JDK-8143245. I figured a smaller fix like this would be more
>>> likely to get accepted as a backport. If you'd rather have JDK-8143245
>>> backported to JDK 8, that would be fine with me too.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8202600
>>> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8202600/webrev.jdk8.01/
>>>
>>> Testing: We've been using this patch downstream for months now without
>>> issues.
>>>
>>> Thanks,
>>> Severin


More information about the hotspot-dev mailing list