RFR (S) 8202684: Minimal VM build is broken after JDK-8199067, JDK-8202638
Erik Osterlund
erik.osterlund at oracle.com
Sat May 5 12:38:29 UTC 2018
The fact that there are more suggests to me there is bigger gain in having a directory that is excluded. But I’m okay with leaving that for another day.
Looks good.
Thanks,
/Erik
> On 5 May 2018, at 14:29, Aleksey Shipilev <shade at redhat.com> wrote:
>
>> On 05/05/2018 02:16 PM, Erik Osterlund wrote:
>> When there are whole cpp files I want to conditionally compile only if a feature is enabled, I
>> prefer adding rules in the make files to not compile those files rather than wrapping the whole
>> file in ifdefs. Is that doable for the test file?
>
> Maybe! Debatable :) I did what's already done for similar test, test_virtualMemoryTracker.cpp [1],
> and that seemed to be the best option for consistency reasons.
>
> -Aleksey
>
> [1]
> http://hg.openjdk.java.net/jdk/jdk/file/88cc95780b6e/test/hotspot/gtest/runtime/test_virtualMemoryTracker.cpp#l29
>
More information about the hotspot-dev
mailing list