RFR (S) 8202684: Minimal VM build is broken after JDK-8199067, JDK-8202638
Aleksey Shipilev
shade at redhat.com
Sat May 5 17:02:59 UTC 2018
On 05/05/2018 04:19 PM, Thomas Stüfe wrote:
> the fix is okay for now, I think. Save that the scale sub option for
> the VM.metaspace jcmd will not work for the minimal build. I think I
> will rewrite this to not use NMT functionality.
Thanks for review! Pushed.
> So, minimal build is something to test too? I already test-build
> nonpch, zero and 32bit before pushing. I really think if these are
> important enough to cause immediate follow up fixes, they all should
> be included into the tier1 tests of oracle.
It would be nice to have at least build tests for most platforms.
I think minimal build falls into "it would be nice to have it non-broken" category. My personal
build server builds many configurations in the matter of course. Build fixes for these configs are
not high priority, as we can always fix up still after the commit.
My own interest in minimal was to check that jdk/jdk after GC interfaces reshuffling, even in these
exotic configurations.
Thanks,
-Aleksey
More information about the hotspot-dev
mailing list