RFR: 8202709: Move oopDesc::is_archive_object to MetaspaceShared::is_archive_object

Erik Helin erik.helin at oracle.com
Tue May 8 06:08:28 UTC 2018


On 05/07/2018 01:37 PM, Stefan Karlsson wrote:
> Hi all,
> 
> Please review this patch to move oopDesc::is_archive_object to 
> MetaspaceShared::is_archive_object.
> 
> http://cr.openjdk.java.net/~stefank/8202709/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8202709

Looks good to me, Reviewed. Before you push, would you mind removing the 
two extra newlines you added prior to the #endif in metaspaceShared.hpp? 
I'm guessing that they weren't meant to be part of the patch :)

Thanks,
Erik

> The motivation for this patch is to move dependencies to G1 out of 
> oopDesc. I've placed the functions in MetaspaceShared, within 
> INCLUDE_CDS_JAVA_HEAP guards, where related functions G1 Archive 
> functions can be found.
> 
> Thanks,
> StefanK


More information about the hotspot-dev mailing list