RFR: 8203220: Introduce ATTRIBUTE_ALIGNED macro

[Thomas Schatzl]

Hi,

On Tue, 2018-05-15 at 17:45 +0200, Per Liden wrote:
> On 05/15/2018 05:07 PM, Thomas Schatzl wrote:
> > Hi,
> > 
> > On Tue, 2018-05-15 at 15:31 +0200, Per Liden wrote:
> > > This patch introduces a global ATTRIBUTE_ALIGNED(x) macro, which
> > > expands
> > > to __attribute__((aligned(x)) or the equivalent of that.
> > > 
> > > [...]
> > > 
> > > Bug: https://bugs.openjdk.java.net/browse/JDK-8203220
> > > Webrev: http://cr.openjdk.java.net/~pliden/8203220/webrev.0
> > 
> >    - it would have been nice to have the ALIGNED_ macro in
> > macroAssembler_* replaced by the new ATTRIBUTE_ALIGNED - there are
> > only a few uses of it and it does not seem worth to have an extra
> > macro in all these places.
> > 
> > Feel free to ignore, but if you change that I do not need to re-
> > review.
> 
> There seem to be ~100 uses of ALIGNED_, but I don't mind changing
> that.

I admit I only looked at the first two files or so, and they did not
use the ALIGNED_ macro a lot.

> 
> Inc: http://cr.openjdk.java.net/~pliden/8203220/webrev.0vs1
> Full: http://cr.openjdk.java.net/~pliden/8203220/webrev.1
> 
> > 
> > Looks good.
> 
> Thanks for reviewing, Thomas!

Still good.

Thomas