RFR (XS) 8203251: Non-PCH build failed after JDK-8199712 (Flight Recorder)

[Markus Gronlund]

Hi Aleksey,

Thanks for being so responsive and sorry for this inconvenience.

Trivial, please put it back.

Many thanks
Markus

Ps will follow on this why this was not caught.

Sent from my iPhone

> On 15 May 2018, at 23:19, Aleksey Shipilev <shade at redhat.com> wrote:
> 
> A few missing includes cause this:
>  https://bugs.openjdk.java.net/browse/JDK-8203251
> 
> This fixes x86_64:
> 
> # HG changeset patch
> # User shade
> # Date 1526419080 -7200
> #      Tue May 15 23:18:00 2018 +0200
> # Node ID 2957fddc6b4ef6b51cb093fb525cb90f952d4fdd
> # Parent  d2cfda6a00de3afb9fe96db0a640e5cd4c597bfc
> 8203251: Non-PCH build failed after JDK-8199712 (Flight Recorder)
> Reviewed-by: XXX
> 
> diff -r d2cfda6a00de -r 2957fddc6b4e src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp
> --- a/src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp    Tue May 15 13:28:08 2018 -0700
> +++ b/src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp    Tue May 15 23:18:00 2018 +0200
> @@ -39,6 +39,7 @@
> #include "memory/resourceArea.hpp"
> #include "runtime/mutexLocker.hpp"
> #include "runtime/orderAccess.inline.hpp"
> +#include "runtime/os.inline.hpp"
> #include "runtime/safepoint.hpp"
> 
> typedef JfrCheckpointManager::Buffer* BufferPtr;
> diff -r d2cfda6a00de -r 2957fddc6b4e src/hotspot/share/jfr/recorder/repository/jfrChunkWriter.cpp
> --- a/src/hotspot/share/jfr/recorder/repository/jfrChunkWriter.cpp    Tue May 15 13:28:08 2018 -0700
> +++ b/src/hotspot/share/jfr/recorder/repository/jfrChunkWriter.cpp    Tue May 15 23:18:00 2018 +0200
> @@ -30,6 +30,7 @@
> #include "jfr/utilities/jfrTypes.hpp"
> #include "runtime/mutexLocker.hpp"
> #include "runtime/os.hpp"
> +#include "runtime/os.inline.hpp"
> 
> const u2 JFR_VERSION_MAJOR = 2;
> const u2 JFR_VERSION_MINOR = 0;
> diff -r d2cfda6a00de -r 2957fddc6b4e
> src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.cpp
> --- a/src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.cpp    Tue May 15 13:28:08 2018
> -0700
> +++ b/src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.cpp    Tue May 15 23:18:00 2018
> +0200
> @@ -32,6 +32,7 @@
> #include "memory/allocation.inline.hpp"
> #include "runtime/mutexLocker.hpp"
> #include "runtime/safepoint.hpp"
> +#include "runtime/os.inline.hpp"
> #include "runtime/task.hpp"
> #include "runtime/vframe.inline.hpp"
> 
> diff -r d2cfda6a00de -r 2957fddc6b4e src/hotspot/share/jfr/recorder/storage/jfrStorage.cpp
> --- a/src/hotspot/share/jfr/recorder/storage/jfrStorage.cpp    Tue May 15 13:28:08 2018 -0700
> +++ b/src/hotspot/share/jfr/recorder/storage/jfrStorage.cpp    Tue May 15 23:18:00 2018 +0200
> @@ -39,6 +39,7 @@
> #include "logging/log.hpp"
> #include "runtime/mutexLocker.hpp"
> #include "runtime/orderAccess.inline.hpp"
> +#include "runtime/os.inline.hpp"
> #include "runtime/safepoint.hpp"
> #include "runtime/thread.hpp"
> 
> Thanks,
> -Aleksey
>