RFR: 8203220: Introduce ATTRIBUTE_ALIGNED macro

Per Liden per.liden at oracle.com
Wed May 16 05:48:52 UTC 2018


On 05/15/2018 07:56 PM, Kim Barrett wrote:
>> On May 15, 2018, at 11:45 AM, Per Liden <per.liden at oracle.com> wrote:
>>
>> On 05/15/2018 05:07 PM, Thomas Schatzl wrote:
>>> Hi,
>>> On Tue, 2018-05-15 at 15:31 +0200, Per Liden wrote:
>>>> This patch introduces a global ATTRIBUTE_ALIGNED(x) macro, which
>>>> expands
>>>> to __attribute__((aligned(x)) or the equivalent of that.
>>>>
>>>> […]
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8203220
>>>> Webrev: http://cr.openjdk.java.net/~pliden/8203220/webrev.0
>>>    - it would have been nice to have the ALIGNED_ macro in
>>> macroAssembler_* replaced by the new ATTRIBUTE_ALIGNED - there are only
>>> a few uses of it and it does not seem worth to have an extra macro in
>>> all these places.
>>> Feel free to ignore, but if you change that I do not need to re-review.
>>
>> There seem to be ~100 uses of ALIGNED_, but I don't mind changing that.
>>
>> Inc: http://cr.openjdk.java.net/~pliden/8203220/webrev.0vs1
>> Full: http://cr.openjdk.java.net/~pliden/8203220/webrev.1
> 
> Still looks good.
> 
> Remember to update the copyrights.
> 

Thanks Kim!

/Per


More information about the hotspot-dev mailing list