RFR (S) 8203278: AArch64/PPC64 build failures after JDK-8199712 (Flight Recorder)

[David Holmes]

That looks better. :)

Thanks,
David

On 16/05/2018 7:27 PM, Aleksey Shipilev wrote:
> On 05/16/2018 10:59 AM, Markus Gronlund wrote:
>> Again, our apologies for having created this extra work for you.
> 
> Yeah, as I said yesterday, it was bound to happen :)
> 
>> Let's see if I can assist you here:
>>
>> If it is the non-definition of thread->thread_state() that is causing problems, I see these three suspect JFR related areas where it is called without (explicitly) including "runtime/thread.inline.hpp (e.g. they only have "runtime/thread.hpp):
>>
>> 1) jfr/jni/jfrJNIMethodRegistration.cpp
>> 2) jfr/leakprofiler/leakprofiler.cpp
>> 3) jfr/checkpoint/types/traceid/jfrTraceId.inline.hpp <<-- probably the most culpable location, causing spread.
> 
> Oh, I get it now! Basically, only (2) and (3) are needed to build on AArch64:
> 
> diff -r bf9177eac58d src/hotspot/share/jfr/leakprofiler/leakProfiler.cpp
> --- a/src/hotspot/share/jfr/leakprofiler/leakProfiler.cpp	Tue May 15 19:26:00 2018 -0400
> +++ b/src/hotspot/share/jfr/leakprofiler/leakProfiler.cpp	Wed May 16 11:25:39 2018 +0200
> @@ -33,7 +33,7 @@
>   #include "oops/oop.hpp"
>   #include "runtime/atomic.hpp"
>   #include "runtime/orderAccess.inline.hpp"
> -#include "runtime/thread.hpp"
> +#include "runtime/thread.inline.hpp"
>   #include "runtime/vmThread.hpp"
>   #include "utilities/ostream.hpp"
> 
> diff -r bf9177eac58d src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.inline.hpp
> --- a/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.inline.hpp	Tue May 15
> 19:26:00 2018 -0400
> +++ b/src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.inline.hpp	Wed May 16
> 11:25:39 2018 +0200
> @@ -34,7 +34,7 @@
>   #include "oops/klass.hpp"
>   #include "oops/instanceKlass.hpp"
>   #include "oops/method.hpp"
> -#include "runtime/thread.hpp"
> +#include "runtime/thread.inline.hpp"
>   #include "utilities/debug.hpp"
> 
>   template <typename T>
> 
> 
> Thanks,
> -Aleksey
>