RFR: 8203288: PPC64 and s390 fail to build after JDK-8199712 (Flight Recorder)

[Gustavo Romero]

Hi Martin,

Even after applying the fix I see the following warning on POWER8 LE:

In file included from /home/gromero/hg/jdk11/jdk/src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp:36:0:
/home/gromero/hg/jdk11/jdk/src/hotspot/share/jfr/utilities/jfrBigEndian.hpp:108:4: warning: #warning "Unconfigured platform" [-Wcpp]
    #warning "Unconfigured platform"
     ^
In file included from /home/gromero/hg/jdk11/jdk/src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp:38:0:
/home/gromero/hg/jdk11/jdk/src/hotspot/share/jfr/utilities/jfrBigEndian.hpp:108:4: warning: #warning "Unconfigured platform" [-Wcpp]
    #warning "Unconfigured platform"


Would that be the root cause?

diff -r 37e6f6f50da0 src/hotspot/share/jfr/utilities/jfrBigEndian.hpp
--- a/src/hotspot/share/jfr/utilities/jfrBigEndian.hpp  Wed May 16 11:11:03 2018 -0400
+++ b/src/hotspot/share/jfr/utilities/jfrBigEndian.hpp  Wed May 16 11:27:53 2018 -0400
@@ -100,7 +100,7 @@
  }
  
  inline bool JfrBigEndian::platform_supports_unaligned_reads(void) {
-#if defined(IA32) || defined(AMD64)
+#if defined(IA32) || defined(AMD64) || defined(PPC64)
    return true;
  #elif defined(SPARC) || defined(ARM) || defined(AARCH64)
    return false;


Best regards,
Gustavo

On 05/16/2018 12:18 PM, Doerr, Martin wrote:
> Hi Aleksey,
> 
> thanks for reviewing. Yes, linux x86_64 still works. I've also pushed it to the submission forest. Waiting for a reply ...
> 
> Best regards,
> Martin
> 
> 
> -----Original Message-----
> From: Aleksey Shipilev [mailto:shade at redhat.com]
> Sent: Mittwoch, 16. Mai 2018 17:07
> To: Doerr, Martin <martin.doerr at sap.com>; hotspot-dev developers (hotspot-dev at openjdk.java.net) <hotspot-dev at openjdk.java.net>
> Cc: Thomas Stüfe <thomas.stuefe at gmail.com>; John Paul Adrian Glaubitz <glaubitz at physik.fu-berlin.de>
> Subject: Re: RFR: 8203288: PPC64 and s390 fail to build after JDK-8199712 (Flight Recorder)
> 
> On 05/16/2018 04:49 PM, Doerr, Martin wrote:
>> It contains a fix in os_perf_linux.cpp which is needed for any linux platforms not supported by Oracle.
> 
>> http://cr.openjdk.java.net/~mdoerr/8203288_ppc64_s390_build/webrev.00/
> 
> Looks fine. I wonder if #include CPU_HEADER would break other platforms, but we shall see.
> Does it still build fine on Linux/x86_64?
> 
> -Aleksey
>