RFR: 8203288: PPC64 and s390 fail to build after JDK-8199712 (Flight Recorder)

[Doerr, Martin]

Hi Aleksey,

I have used --disable-warnings-as-errors as workaround. Maybe I can fix the warning tomorrow, too.

Best regards,
Martin


-----Original Message-----
From: Aleksey Shipilev [mailto:shade at redhat.com] 
Sent: Mittwoch, 16. Mai 2018 18:24
To: Doerr, Martin <martin.doerr at sap.com>; hotspot-dev developers (hotspot-dev at openjdk.java.net) <hotspot-dev at openjdk.java.net>
Cc: Thomas Stüfe <thomas.stuefe at gmail.com>; John Paul Adrian Glaubitz <glaubitz at physik.fu-berlin.de>
Subject: Re: RFR: 8203288: PPC64 and s390 fail to build after JDK-8199712 (Flight Recorder)

On 05/16/2018 05:18 PM, Doerr, Martin wrote:
> thanks for reviewing. Yes, linux x86_64 still works. I've also pushed it to the submission forest. Waiting for a reply ...

Realized I can actually build the patch myself.

So, CPU_HEADER seems to work, but the patch itself is incomplete.

Tested:

--- x86_64-server:     builds fine
--- x86_32-server:     builds fine
--- x86_32-minimal:    builds fine
--- aarch64-server:    builds fine
--- arm32-hflt-server: builds fine

--- ppc64le-server: still fails with:

/home/shade/jdk-jdk/src/hotspot/share/jfr/utilities/jfrBigEndian.hpp:108:4: warning: #warning
"Unconfigured platform" [-Wcpp]
   #warning "Unconfigured platform"
    ^~~~~~~
In file included from
/home/shade/jdk-jdk/src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp:38:0:
/home/shade/jdk-jdk/src/hotspot/share/jfr/utilities/jfrBigEndian.hpp:108:4: warning: #warning
"Unconfigured platform" [-Wcpp]
   #warning "Unconfigured platform"
    ^~~~~~~

--- s390x-server: still fails with:

In file included from
/home/shade/jdk-jdk/src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp:36:0:
/home/shade/jdk-jdk/src/hotspot/share/jfr/utilities/jfrBigEndian.hpp:108:4: warning: #warning
"Unconfigured platform" [-Wcpp]
   #warning "Unconfigured platform"
    ^~~~~~~
In file included from
/home/shade/jdk-jdk/src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp:38:0:
/home/shade/jdk-jdk/src/hotspot/share/jfr/utilities/jfrBigEndian.hpp:108:4: warning: #warning
"Unconfigured platform" [-Wcpp]
   #warning "Unconfigured platform"
    ^~~~~~~

-Aleksey