RFR(XXS): 8203346: JFR: Inconsistent signature of jfr_add_string_constant

[David Holmes]

I'm intrigued as to how/why this would only cause a problem on 32-bit 
windows ?? What version of Visual Studio was it?

David

On 17/05/2018 8:40 PM, Markus Gronlund wrote:
> Greetings,
> 
>   
> 
> Please see this tiny fix for the following bug:
> 
>   
> 
> https://bugs.openjdk.java.net/browse/JDK-8203346
> 
>   
> 
> Change:
> 
>   
> 
> # HG changeset patch
> 
> # User mgronlun
> 
> # Date 1526553151 -7200
> 
> #      Thu May 17 12:32:31 2018 +0200
> 
> # Node ID 9ac9ae21cc4c872ab40bb2c171dda3a921aa25fb
> 
> # Parent  8e4fcfb4cfe48e6b481c6aa1751d916014a826af
> 
> 8203346: JFR: Inconsistent signature of jfr_add_string_constant
> 
> Reviewed-by:
> 
>   
> 
> diff --git a/src/hotspot/share/jfr/jni/jfrJniMethod.hpp b/src/hotspot/share/jfr/jni/jfrJniMethod.hpp
> 
> --- a/src/hotspot/share/jfr/jni/jfrJniMethod.hpp
> 
> +++ b/src/hotspot/share/jfr/jni/jfrJniMethod.hpp
> 
> @@ -117,7 +117,7 @@
> 
>   
> 
> jlong JNICALL jfr_get_epoch_address(JNIEnv* env, jobject jvm);
> 
>   
> 
> -jlong JNICALL jfr_add_string_constant(JNIEnv* env, jclass jvm, jlong gen, jlong id, jstring string);
> 
> +jlong JNICALL jfr_add_string_constant(JNIEnv* env, jclass jvm, jboolean epoch, jlong id, jstring string);
> 
>   
> 
> void JNICALL jfr_uncaught_exception(JNIEnv* env, jobject jvm, jobject thread, jthrowable throwable);
> 
>   
> 
>   
> 
> Thanks to Martin for reporting, sorry for the inconvenience
> 
>   
> 
> Markus
>