8203287: Zero fails to build after JDK-8199712 (Flight Recorder)

Aleksey Shipilev shade at redhat.com
Thu May 17 13:27:32 UTC 2018


On 05/17/2018 03:12 PM, Severin Gehwolf wrote:
> Hi Martin, Aleksey,
> 
> Since JDK-8203288 has been pushed here is the latest webrev for Zero.
> It no longer contains changes in os_perf_linux.cpp.
> 
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8203287/webrev.02/
> 
> How does it look?

Looks good, but I used parentheses inconsistently with the rest of Hotspot in the original patch:

 #if (defined X86 && !defined ZERO)

Should be:

 #if defined(X86) && !defined (ZERO)

-Aleksey



More information about the hotspot-dev mailing list