8203287: Zero fails to build after JDK-8199712 (Flight Recorder)

[Severin Gehwolf]

Hi Martin, Aleksey,

Ugh, sorry, my mistake :-/ Thanks for the reviews!

This is what I'm going to push once jdk-submit comes back clean:

http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8203287/webrev.04/

Thanks,
Severin

On Thu, 2018-05-17 at 14:17 +0000, Doerr, Martin wrote:
> Hi Severin,
> 
> looks good to me with Aleksey's patch. Thanks for waiting.
> 
> Best regards,
> Martin
> 
> 
> -----Original Message-----
> From: Aleksey Shipilev [mailto:shade at redhat.com] 
> Sent: Donnerstag, 17. Mai 2018 16:14
> To: Severin Gehwolf <sgehwolf at redhat.com>; Doerr, Martin <martin.doerr at sap.com>; hotspot-dev <hotspot-dev at openjdk.java.net>
> Subject: Re: 8203287: Zero fails to build after JDK-8199712 (Flight Recorder)
> 
> On 05/17/2018 04:02 PM, Severin Gehwolf wrote:
> > On Thu, 2018-05-17 at 15:27 +0200, Aleksey Shipilev wrote:
> > > On 05/17/2018 03:12 PM, Severin Gehwolf wrote:
> > > > Hi Martin, Aleksey,
> > > > 
> > > > Since JDK-8203288 has been pushed here is the latest webrev for Zero.
> > > > It no longer contains changes in os_perf_linux.cpp.
> > > > 
> > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8203287/webrev.02/
> > > > 
> > > > How does it look?
> > > 
> > > Looks good, but I used parentheses inconsistently with the rest of Hotspot in the original patch:
> > > 
> > >  #if (defined X86 && !defined ZERO)
> > > 
> > > Should be:
> > > 
> > >  #if defined(X86) && !defined (ZERO)
> > 
> > OK. Here it goes:
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8203287/webrev.03/
> 
> Notice the parentheses, it is done like that in other places:
> 
>  #if defined(X86) && !defined(ZERO)
> 
> Apply this patch to correct:
>   http://cr.openjdk.java.net/~shade/8203287/parent.patch
> 
> I checked it builds with x86_64 and Zero.
> 
> -Aleksey
>