8203287: Zero fails to build after JDK-8199712 (Flight Recorder)

Severin Gehwolf sgehwolf at redhat.com
Fri May 18 11:27:44 UTC 2018


On Fri, 2018-05-18 at 13:10 +0200, Aleksey Shipilev wrote:
> But Zero is already broken, and there are two fixes:
>  1. Make Zero build again.
>  2. Make Zero compatible with JFR.
> 
> I see no sense in waiting for (2), when (1) is ready. New code does not break the Zero portability
> per se, it renders Zero+JFR non-working on some platforms, but that is for (2).

Exactly, I'm going to push this fix now as a broken build opens the
door for more Zero build breakage and leave the rest for (2).

Thanks,
Severin

> -Aleksey
> 
> On 05/18/2018 11:41 AM, John Paul Adrian Glaubitz wrote:
> > I agree. Please don’t break portability of Zero here.
> > 
> > I haven’t had the time to look into this yet, but I will try to
> > catch up the next days and see where I can help.
> > 
> > Adrian
> > 
> > > On May 18, 2018, at 11:24 AM, David Holmes <david.holmes at oracle.c
> > > om> wrote:
> > > 
> > > Hi Severin,
> > > 
> > > It sounds like parts of os_perf should be conditional on
> > > INCLUDE_JFR (which I think replaced INCLUDE_TRACE). But I haven't
> > > been able to look at the Flight Recorder changes in detail.
> > > 
> > > You obviously need to do what you need to move forward but
> > > something seems wrong here.
> 
> 
> 


More information about the hotspot-dev mailing list