RFR: 8199064: Test applications/jcstress/other/Test.java#id1108 fails on Sparc

[Leonid Mesnik]

Paul

Thank you for review. You are right, I just forget to mention that most if files are generated.
I agree that this timeout is very high for most of tests. However please note that:
1) It affect execution time only when test really hang and killed by timeout.
2) These tests are executed in hotspot tier7 only. They are executed once a week during PIT only and during ATR testing only.

So I think that we don't need to optimize them right now. Please file RFE if you think that it is worth to improve it. 


Leonid


> On May 17, 2018, at 6:41 PM, Paul Sandoz <paul.sandoz at oracle.com> wrote:
> 
> Looks good.
> 
> I was initially taken aback by all the changes but quickly realized they are all generated, the important change being in TestGenerator.java.
> 
> Do you have a sense of the range of times based on the JcstressGroup? I wonder if we could be a little smarter on timeout value.
> 
> Paul.
> 
>> On May 16, 2018, at 3:14 PM, Leonid Mesnik <Leonid.Mesnik at oracle.com> wrote:
>> 
>> Hi
>> 
>> Could you please review following patch which increase timeout for jcstress test wrappers in jtreg.
>> 
>> The default jtreg timeout is not enough for a lot of jcstress tests. The longest tests take more then 1800 seconds on typical VM used for testing (2 CPU/16GB of Memory) with default VM options.
>> These tests are not executed in tier1/2 testing so execution time in the case if test really hang is not very critical. I just set timeout to 2400 seconds for all test wrappers. 
>> The timeoutfactor could be used to adjust timeouts for slow platforms and/or VM options. 
>> 
>> 
>> webrev: http://cr.openjdk.java.net/~lmesnik/8199064/webrev.00/ <http://cr.openjdk.java.net/~lmesnik/8199064/webrev.00/>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8199064 <https://bugs.openjdk.java.net/browse/JDK-8199064>
>> 
>> Leonid
>