RFR 8203381 Replace InstanceKlass::allocate_instance_handle with JavaCalls::construct_new_instance

yumin qi yumin.qi at gmail.com
Fri May 18 18:04:45 UTC 2018


Hi, Ioi

  Very nice clean-up for Thread creation.
  One question, should we replace all  the JavaCalls::call_special with
JavaCalls::construct_new_instance (there are three versions) and make
JavaCalls::call_special
an internal implementation? I did see many places using
JavaCalls::call_special.

Thanks
Yumin

On Fri, May 18, 2018 at 9:36 AM, Ioi Lam <ioi.lam at oracle.com> wrote:

> https://bugs.openjdk.java.net/browse/JDK-8203381
> http://cr.openjdk.java.net/~iklam/jdk11/8203381-construct-ne
> w-instance.v01/
>
> This patch removes a lot of the boilerplate code for allocating a
> Java object and calling its constructor. Hopefully the code is cleaner
> and easier to read.
>
> Also:
>
> Added assert(InstanceKlass::is_initialized(), ...) in case where
> we cannot call JavaCalls::construct_new_instance for thread objects.
>
> Replaced unnecessary SystemDictionary::resolve_or_null() calls with
> SystemDictionary::XXX_klass().
>
> Tested with hs-tier[1,2,3,4,5]
>
> Thanks
> - Ioi
>
>
>
>
>
>


More information about the hotspot-dev mailing list