RFR(XS) : 8203437 : 8199370 broke build on linux-ppc64le (w/ GCC 4.8.5.)

[Doerr, Martin]

Hi Igor,

sorry that I couldn't reply earlier. Thank you for fixing this issue.

Best regards,
Martin


-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Igor Ignatyev
Sent: Freitag, 18. Mai 2018 21:38
To: Aleksey Shipilev <shade at redhat.com>
Cc: hotspot-dev Source Developers <hotspot-dev at openjdk.java.net>
Subject: Re: RFR(XS) : 8203437 : 8199370 broke build on linux-ppc64le (w/ GCC 4.8.5.)



> On May 18, 2018, at 11:48 AM, Aleksey Shipilev <shade at redhat.com> wrote:
> 
> On 05/18/2018 08:38 PM, Igor Ignatyev wrote:
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8203437
>> webrev: http://cr.openjdk.java.net/~iignatyev//8203437/webrev.00
> 
> Looks OK. Not immediately evident why only those two fields require initialization. 
> 
>> testing: 'make test-image' w/ gcc4.8.2.
> 
> Interestingly, my ppc64le builds are fine without this fix. Do I need to add "test-image" to CI
> scripts to compile the tests too?

I've double-checked 'make images' doesn't build test image, actually it's just an alias for 'product-images', so yes 'test-image' is needed to compile native part of tests. alternatively, you can use 'all-images' target which builds product, test and doc images.

-- Igor
> 
> -Aleksey
>