RFR: AArch64: 8203699 java/lang/invoke/SpecialInterfaceCall fails with SIGILL on aarch64

White, Derek Derek.White at cavium.com
Fri May 25 00:40:29 UTC 2018


Hi Andrew,

Both versions look good to me.

 - Derek

> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On
> Behalf Of Aleksey Shipilev
> Sent: Thursday, May 24, 2018 6:52 AM
> To: Andrew Dinn <adinn at redhat.com>; hotspot-dev Source Developers
> <hotspot-dev at openjdk.java.net>
> Subject: Re: RFR: AArch64: 8203699 java/lang/invoke/SpecialInterfaceCall
> fails with SIGILL on aarch64
> 
> On 05/24/2018 12:07 PM, Andrew Dinn wrote:
> > On 23/05/18 20:34, Andrew Dinn wrote:
> > So, I propose correcting patch to
> >
> >    push(pushed_registers, sp);
> >
> > +  if (super_klass != r0) {
> > +    mov(r0, super_klass);
> > +  }
> >
> > Revised webrev: http://cr.openjdk.java.net/~adinn/8203699/webrev.01/
> 
> OK, fine. Although I see no pragmatic reason to spend more time on
> polishing this code, and forcing reviewers to re-review and re-test. I assume
> you have tested the new change?
> 
> -Aleksey
> 



More information about the hotspot-dev mailing list