RFR: 8204167: Filter out tests requiring compressed oops when CompressedOops is disabled

Stefan Karlsson stefan.karlsson at oracle.com
Thu May 31 19:59:19 UTC 2018


On 2018-05-31 21:20, Kim Barrett wrote:
>> On May 31, 2018, at 8:09 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
>>
>> Hi all,
>>
>> Please review this patch to add @requires vm.opt.final.UseCompressedOops to those jtreg tests that requires compressed oops.
>>
>> http://cr.openjdk.java.net/~stefank/8204167/webrev.01/
>> https://bugs.openjdk.java.net/browse/JDK-8204167
>>
>> With this patch we now filter out tests that require compressed oops, when -XX:-UseCompressedOops is passed or ZGC is tested.
>>
>> Thanks,
>> StefanK
> test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java
> test/hotspot/jtreg/runtime/CompressedOops/CompressedClassSpaceSize.java
> test/hotspot/jtreg/runtime/Metaspace/MaxMetaspaceSizeTest.java
>
> These seem to be testing UseCompressedClassPointers rather than
> UseCompressedOops.  Shouldn't they require UseCompressedClassPointers
> instead?  I know UCCP requires UCO, but requiring UCO here seems odd.

Yes, that makes sense. New webrevs:

http://cr.openjdk.java.net/~stefank/8204167/webrev.02.delta/
http://cr.openjdk.java.net/~stefank/8204167/webrev.02/

Thanks,
StefanK




More information about the hotspot-dev mailing list