RFR(XS) : 8177711 : Convert TestVirtualSpaceNode_test to GTest
jesper.wilhelmsson at oracle.com
jesper.wilhelmsson at oracle.com
Thu Nov 1 01:24:51 UTC 2018
Looks good!
/Jesper
> On 1 Nov 2018, at 01:25, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>
> a friendly reminder, could someone Review this?
> -- Igor
>
>> On Oct 24, 2018, at 11:50 AM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>
>> http://cr.openjdk.java.net/~iignatyev//8177711/webrev.00/index.html
>>> 405 lines changed: 244 ins; 159 del; 2 mod;
>>
>>
>> Hi all,
>>
>> could you please review this small and straightforward patch which converts TestVirtualSpaceNode_test into GTest? TestVirtualSpaceNode_test have been removed from executed by 8198423[1] and some of its asserts aren't true any more. I have them commented them out, and filed 8212932[2] to clean them up.
>>
>> webrev: http://cr.openjdk.java.net/~iignatyev//8177711/webrev.00/index.html
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8177711
>>
>> Thanks,
>> -- Igor
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8198423
>> [2] https://bugs.openjdk.java.net/browse/JDK-8212932
>>
>
More information about the hotspot-dev
mailing list