RFR(XS/trivial) : 8213337 : windows-x64-slowdebug build is broken by 8177708

Igor Ignatyev igor.ignatyev at oracle.com
Sat Nov 3 06:35:49 UTC 2018


http://cr.openjdk.java.net/~iignatyev//8213337/webrev.00/index.html
> 1 line changed: 1 ins; 0 del; 0 mod;

Hi all,

could you please review this small and trivial fix? test/hotspot/gtest/runtime/test_os_windows.cpp (created by 8177708) uses FLAG_SET_CMDLINE defined in runtime/globals_extension.hpp, but doesn't include this file neither explicitly nor implicitly. this affects only on build w/ disabled precompiled headers, and windows-x64-slowdebug is the only regularly windows build which has precompiled headers disabled.

testing: windows-x64-slowdebug, tier1
webrev: http://cr.openjdk.java.net/~iignatyev//8213337/webrev.00/index.html
JBS: https://bugs.openjdk.java.net/browse/JDK-8213337

Thanks,
-- Igor


More information about the hotspot-dev mailing list