RFR: 8212996: Use AS_NO_KEEPALIVE when accessing dead java.lang.invoke.CallSites during nmethod unloading

Erik Österlund erik.osterlund at oracle.com
Mon Nov 5 10:14:21 UTC 2018


Hi Per,

Thanks for the review.

/Erik

On 2018-11-05 11:02, Per Liden wrote:
> Hi Erik,
>
> On 10/25/18 9:29 PM, Erik Österlund wrote:
>> Hi,
>>
>> When nmethods are unloaded, they may have dead 
>> java.lang.invoke.CallSites loaded, and then we follow their dead 
>> java.lang.invoke.MethodHandleNatives.CallSiteContext, so that its 
>> dependency context can be cleaned. These dead oops should be loaded 
>> with AS_NO_KEEPALIVE accessors, otherwise GC barriers can become very 
>> unhappy.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~eosterlund/8212996/webrev.00/
>
> Looks good to me!
>
> /Per
>
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8212996
>>
>> Thanks,
>> /Erik



More information about the hotspot-dev mailing list