RFR(s): 8211403: Rename SafepointMechanism::poll(...)

[Robbin Ehn]

Hi David,

On 2018-11-07 10:32, David Holmes wrote:
> Hi Robbin,
> 
> On 7/11/2018 6:32 PM, Robbin Ehn wrote:
>> Hi all, please review.
>>
>> We rename SafepointMechanism::poll to SafepointMechanism::should_block to make 
>> it more clear what the method do.
> 
> Fair enough, but doesn't that just imply that global_poll and local_poll are 
> also mis-named? How far should this rename go?

I think they are fine, because of the different context. As I see it
should_block is implemented by actively checking (polling) the threads page or
the global state.

Thanks, Robbin

> 
> Thanks,
> David
> 
>>
>> CR: https://bugs.openjdk.java.net/browse/JDK-8211403
>> Webrev: http://cr.openjdk.java.net/~rehn/8211403/webrev/
>>
>> Sanity on tier 1.
>>
>> Thanks, Robbin