RFR (S) 8211926: Catastrophic size_t underflow in BitMap::*_large methods

Aleksey Shipilev shade at redhat.com
Fri Nov 9 09:33:49 UTC 2018


On 11/09/2018 02:36 AM, Kim Barrett wrote:
>> I believe new patch is as straightforward as it could be, see:
>>  http://cr.openjdk.java.net/~shade/8211926/webrev.03/
> 
> I was about ready to approve, but took another look at the new test.
> Unfortunately, I think it has some problems.

Okay, let's try again after fixing the problems you mentioned:
  http://cr.openjdk.java.net/~shade/8211926/webrev.04/

Moved STATIC_ASSERT and comments to the actual use site, rewritten test. Test takes 0.5s per TEST().
Looks good now?

-Aleksey



More information about the hotspot-dev mailing list