RFR : 8211326 : add OS user related information to hs_err file

[Thomas Stüfe]

Hi David,

On Sat, Nov 10, 2018 at 12:59 PM David Holmes <david.holmes at oracle.com> wrote:
>
> Hi Matthias,
>
> On 9/11/2018 3:13 AM, Baesken, Matthias wrote:
> > Hello  , after the flag   "-XX:+-ExtensiveErrorReports"   make it into jdk/jdk  , I created another webrev :
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8211326.1/
> >
> >
> > The user info output is now guarded  by ExtensiveErrorReports .
>
> +   STEP("printing user info")
> +      if (ExtensiveErrorReports) {
> +        if (_verbose) {
> +          os::Posix::print_user_info(st, buf, sizeof(buf));
> +        }
> +      }
>
> I don't understand why we explicitly need _verbose if we've asked for
> ExtensiveErrorreports?

That flag has a different purpose: _verbose distinguishes the two
calls to VMError::report(): the first one to print a small report to
stderr, the second print a large report to the hs-err file. We only
want to print to the hs-err file, so _verbose is still needed.

>
> Also, ideally the STEP would be inside the guard as otherwise we will
> just print the step description followed by nothing. If the macro
> expansion makes that impossible then we should have an else clause that
> prints something like:
>
>   - disabled (use -XX:+ExtensiveErrorReports to see these details)
>

We may even go a step further (but in a separate patch) and make
"ExtensiveErrorReports" a property of the STEP, to be given as
parameter of the STEP macro.

Thanks, Thomas

> Thanks,
> David
> -----
>
> > Please review!
> >
> >
> > Thanks, Matthias
> >
> >
> >> -----Original Message-----
> >> From: Baesken, Matthias
> >> Sent: Dienstag, 9. Oktober 2018 16:55
> >> To: 'Thomas Stüfe' <thomas.stuefe at gmail.com>; David Holmes
> >> <david.holmes at oracle.com>
> >> Cc: Langer, Christoph <christoph.langer at sap.com>; Volker Simonis
> >> <volker.simonis at gmail.com>; HotSpot Open Source Developers <hotspot-
> >> dev at openjdk.java.net>
> >> Subject: RE: RFR : 8211326 : add OS user related information to hs_err file
> >>
> >> Hi Thomas ,  thanks for filing the CSR .
> >>
> >> I am fine with the name proposal   "-XX:+-ExtensiveErrorReports",   but will
> >> wait  until it is agreed to use this name .
> >> Then I'll post another webrev  of  8211326  using the flag .
> >>
> >> Best regards, Matthias
> >>
> >>
> >>
> >>> -----Original Message-----
> >>> From: Thomas Stüfe <thomas.stuefe at gmail.com>
> >>> Sent: Montag, 8. Oktober 2018 12:21
> >>> To: David Holmes <david.holmes at oracle.com>
> >>> Cc: Baesken, Matthias <matthias.baesken at sap.com>; Langer, Christoph
> >>> <christoph.langer at sap.com>; Volker Simonis
> >> <volker.simonis at gmail.com>;
> >>> HotSpot Open Source Developers <hotspot-dev at openjdk.java.net>
> >>> Subject: Re: RFR : 8211326 : add OS user related information to hs_err file
> >>>
> >>> On Mon, Oct 8, 2018 at 11:50 AM David Holmes
> >> <david.holmes at oracle.com>
> >>> wrote:
> >>>>
> >>>> Hi Thomas,
> >>>>
> >>>> On 8/10/2018 7:43 PM, Thomas Stüfe wrote:
> >>>>> Hi all,
> >>>>>
> >>>>> I drafted a CSR:
> >>>>>
> >>>>> https://bugs.openjdk.java.net/browse/JDK-8211846
> >>>>>
> >>>>> Not sure what to do now, should I open a discussion thread on a
> >>>>> mailing list? Or just wait for the committee to decide? (I'm doing
> >>>>> this too rarely..)
> >>>>
> >>>> I filled in some of the additional info needed. The text needs to be
> >>>> completed and the CSR needs to have at least one reviewer added to it.
> >>>> Then it can be marked "final" and ready for the committee to evaluate.
> >>>>
> >>>
> >>> Thanks! I filled out what was missing and will wait for reviewers.
> >>>
> >>> Thanks, Thomas
> >>>
> >