RFR: 8213503: Build failure for SerialGC-only JDK

David Holmes david.holmes at oracle.com
Mon Nov 12 05:41:50 UTC 2018


Hi Kim,

On 12/11/2018 2:37 PM, Kim Barrett wrote:
> Please review this small (trivial?) change, fixing some G1GC
> conditionalizations so that it is possible to configure and build a
> JDK that only provides SerialGC.
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8213503
> 
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8213503/open.00/

That's one way to make it build, but ... I have to wonder whether the 
whole definition of the G1HeapRegionTypeConstant class and the 
registration of it:

  register_type(TYPE_G1HEAPREGIONTYPE, false, true, new 
G1HeapRegionTypeConstant());

shouldn't all be conditional on having G1?

Thanks,
David
-----

> Testing:
> mach5 tier1 (mostly to verify changes still build normally).
> Local build (linux-x64) configured with
>    --with-jvm-features=-cmsgc,-epsilongc,-g1gc,-parallelgc,-zgc
> 


More information about the hotspot-dev mailing list