RFR: AArch64: 8209415: Fix JVMTI test failure HS202

JC Beyler jcbeyler at google.com
Tue Nov 13 16:54:51 UTC 2018


Hi Andrew,

Not a reviewer but had fun finding the two bugs before looking at the
webrev :). Looks good to me!
Jc

On Tue, Nov 13, 2018 at 8:41 AM Andrew Haley <aph at redhat.com> wrote:

> In a moment of madness one of us (no names, no pack drill!)  managed
> to translate from x86
>
>     __ cmpb(Address(rbcp, 0), Bytecodes::_invokestatic);
>     __ jcc(Assembler::notEqual, L_done);
>
> to
>
>     __ ldrb(rscratch1, Address(rbcp, 0));
>     __ cmpw(r1, Bytecodes::_invokestatic);
>     __ br(Assembler::EQ, L_done);
>
> Two bugs in thee lines... fixed thusly.
>
> http://cr.openjdk.java.net/~aph/8209415/
>
> OK for trunk and jdk8u ?
>
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
>


-- 

Thanks,
Jc


More information about the hotspot-dev mailing list