RFR : 8211326 : add OS user related information to hs_err file

[David Holmes]

Hi Matthias,

On 15/11/2018 3:16 am, Baesken, Matthias wrote:
> Hi Thomas , so are you fine with the latest revision
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8211326.1/
> 
> of the patch ,  can I add you as reviewer ?
> 
> David - is the info added by Thomas sufficient for you?

Thomas explained about _verbose. I still have concerns that we will 
print the header but then no info - I think that needs to be addressed.

I did not review the actual print_user_info as I'm not familiar with the 
actual content.

Thanks,
David

> Any other reviewers ?
> 
> 
> 
>> -----Original Message-----
>> From: Thomas Stüfe <thomas.stuefe at gmail.com>
>> Sent: Samstag, 10. November 2018 14:04
>> To: David Holmes <david.holmes at oracle.com>
>> Cc: Baesken, Matthias <matthias.baesken at sap.com>; Langer, Christoph
>> <christoph.langer at sap.com>; Volker Simonis <volker.simonis at gmail.com>;
>> HotSpot Open Source Developers <hotspot-dev at openjdk.java.net>
>> Subject: Re: RFR : 8211326 : add OS user related information to hs_err file
>>
>> Hi David,
>>
>> On Sat, Nov 10, 2018 at 12:59 PM David Holmes <david.holmes at oracle.com>
>> wrote:
>>>
>>> Hi Matthias,
>>>
>>> On 9/11/2018 3:13 AM, Baesken, Matthias wrote:
>>>> Hello  , after the flag   "-XX:+-ExtensiveErrorReports"   make it into jdk/jdk
>> , I created another webrev :
>>>>
>>>> http://cr.openjdk.java.net/~mbaesken/webrevs/8211326.1/
>>>>
>>>>
>>>> The user info output is now guarded  by ExtensiveErrorReports .
>>>
>>> +   STEP("printing user info")
>>> +      if (ExtensiveErrorReports) {
>>> +        if (_verbose) {
>>> +          os::Posix::print_user_info(st, buf, sizeof(buf));
>>> +        }
>>> +      }
>>>
>>> I don't understand why we explicitly need _verbose if we've asked for
>>> ExtensiveErrorreports?
>>
>> That flag has a different purpose: _verbose distinguishes the two
>> calls to VMError::report(): the first one to print a small report to
>> stderr, the second print a large report to the hs-err file. We only
>> want to print to the hs-err file, so _verbose is still needed.
>>
>>>
>>> Also, ideally the STEP would be inside the guard as otherwise we will
>>> just print the step description followed by nothing. If the macro
>>> expansion makes that impossible then we should have an else clause that
>>> prints something like:
>>>
>>>    - disabled (use -XX:+ExtensiveErrorReports to see these details)
>>>
>>
>> We may even go a step further (but in a separate patch) and make
>> "ExtensiveErrorReports" a property of the STEP, to be given as
>> parameter of the STEP macro.
>>
>> Thanks, Thomas
>>
>