RFR : 8211326 : add OS user related information to hs_err file

[Baesken, Matthias]

Hi Thomas and  David,  

new webrev :

http://cr.openjdk.java.net/~mbaesken/webrevs/8211326.4/

This includes David's comment

>  My only quibble is about the treatment of uid_t
> and gid_t as being the same. It would be marginally cleaner to me if the
> cast to unsigned was done upfront on the library call:
>

 and adjusts the STEP-coding (removed else ...  part ) .

David - can I add you as reviewer (Thomas was fine with the change already) ?

Thanks, Matthias


> -----Original Message-----
> From: David Holmes <david.holmes at oracle.com>
> Sent: Donnerstag, 15. November 2018 14:38
> To: Baesken, Matthias <matthias.baesken at sap.com>; Thomas Stüfe
> <thomas.stuefe at gmail.com>
> Cc: Langer, Christoph <christoph.langer at sap.com>; Volker Simonis
> <volker.simonis at gmail.com>; HotSpot Open Source Developers <hotspot-
> dev at openjdk.java.net>
> Subject: Re: RFR : 8211326 : add OS user related information to hs_err file
> 
> On 15/11/2018 11:20 pm, Baesken, Matthias wrote:
> > I'll remove the else - but I think I need a second reviewer, isn’t it ?
> 
> I hadn't reviewed the actual printing of the user info but now I have
> had a good look at it. My only quibble is about the treatment of uid_t
> and gid_t as being the same. It would be marginally cleaner to me if the
> cast to unsigned was done upfront on the library call:
> 
> unsigned id = (unsigned) ::getuid();
> st->print("uid  : %u ", id);
> id = (unsigned) ::geteuid();
> ...
> id = (unsigned) ::getgid();
> ...
> 
> Thanks,
> David
> -----
> 
> > Best regards, Matthias
> >
> >> -----Original Message-----
> >> From: Thomas Stüfe <thomas.stuefe at gmail.com>
> >> Sent: Donnerstag, 15. November 2018 14:15
> >> To: David Holmes <david.holmes at oracle.com>
> >> Cc: Baesken, Matthias <matthias.baesken at sap.com>; Langer, Christoph
> >> <christoph.langer at sap.com>; Volker Simonis
> <volker.simonis at gmail.com>;
> >> HotSpot Open Source Developers <hotspot-dev at openjdk.java.net>
> >> Subject: Re: RFR : 8211326 : add OS user related information to hs_err file
> >>
> >> On Thu, Nov 15, 2018 at 1:43 PM David Holmes
> <david.holmes at oracle.com>
> >> wrote:
> >>>
> >>> On 15/11/2018 10:33 pm, Thomas Stüfe wrote:
> >>>> I'm fine with this, Matthias.
> >>>>
> >>>> BTW, I looked and the STEP header line is only printed when secondary
> >>>> exceptions happen inside the step, not always as David assumed (?). So
> >>>
> >>> Yes my bad - sorry.
> >>
> >> no problem. I did not see it right away either.
> >>
> >>>
> >>>> your first form
> >>>>
> >>>> STEP("blabla")
> >>>>     if (ExtensiveErrorReports && _verbose) {
> >>>>        blub
> >>>>     }
> >>>>
> >>>> would have been fine too I think. But I do not want to send you
> >>>> through another review iteration, so I am fine with this version.
> >>>
> >>> Deleting the else doesn't need another round of review.
> >>
> >> Same from me. Remove the else path and ship it.
> >>
> >> ..Thomas
> >>