RFR 8213751: ClassLoaderDataGraph::cld_do() should sometimes require CLDG_lock
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Fri Nov 16 11:42:02 UTC 2018
Thanks Erik and Robbin!
Coleen
On 11/16/18 3:59 AM, Robbin Ehn wrote:
> On 11/16/18 7:48 AM, Erik Österlund wrote:
>> Hi Coleen,
>>
>> Looks good.
>
> +1
>
> /Robbin
>
>>
>> Thanks,
>> /Erik
>>
>> On 2018-11-15 23:50, coleen.phillimore at oracle.com wrote:
>>>
>>> ErikO and I had some offline conversation about the function naming,
>>> and decided on cld_do() to follow all CLDs and loaded_cld_do() to
>>> only follow the loaded CLDS, so I've reverted some of the GC
>>> cld_oops_do() changes. Also always_strong_loaded_cld_do() doesn't
>>> make sense, so I removed that.
>>>
>>> Incremental (somewhat of a revert)
>>> http://cr.openjdk.java.net/~coleenp/8213751.02.incr/webrev/index.html
>>> Full: http://cr.openjdk.java.net/~coleenp/8213751.02/webrev/index.html
>>>
>>> Reran serviceability tests and JFR tests.
>>>
>>> Thanks,
>>> Coleen
>>>
>>> On 11/14/18 7:44 AM, coleen.phillimore at oracle.com wrote:
>>>> Summary: Give GC own version of cld_oops_do and use cld_do for
>>>> runtime calls.
>>>>
>>>> This also adds a NoSafepointVerifier in the CLDG iterator.
>>>>
>>>> Tested with hs-tier1-3, vmTestbase/nsk, gc, runtime and JFR tests
>>>> locally.
>>>>
>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8213751.01/webrev
>>>> bug link https://bugs.openjdk.java.net/browse/JDK-8213751
>>>>
>>>> Thanks,
>>>> Coleen
>>>
>>
More information about the hotspot-dev
mailing list