RFR(XXS): 8214001: DependencyContext::remove_dependent_nmethod() deletion in place is unnecessary
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Fri Nov 16 21:46:14 UTC 2018
Hi Zhengyu, your change conflicts with one that ErikO has out for review:
RFR: 8213565: Crash in DependencyContext::remove_dependent_nmethod
http://cr.openjdk.java.net/~eosterlund/8213565/webrev.00/src/hotspot/share/code/dependencyContext.cpp.udiff.html
All he needs is someone who understands this code to review it!
Thanks,
Coleen
On 11/16/18 4:38 PM, Zhengyu Gu wrote:
> Hi,
>
> Please review this small cleanup.
>
> It is not necessary to delete stale entry in place, since it calls
> expunge_stale_entries() to purge all stale entries at the end anyway.
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214001
> Webrev: http://cr.openjdk.java.net/~zgu/8214001/webrev.00/
>
> Test:
>
> hotspot_compiler on Linux x64 (fastdebug and release)
>
> Thanks,
>
> -Zhengyu
>
>
>
>
More information about the hotspot-dev
mailing list