RFR(T): 8214206: Fix for JDK-8213419 is broken on 32-bit

[Doerr, Martin]

Hi Roland,

webrev.02 seems to work. But I still wonder why we should have a version which only casts to unsigned.

Thanks and best regards,
Martin


-----Original Message-----
From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of Doerr, Martin
Sent: Freitag, 23. November 2018 10:15
To: Roland Westrelin <rwestrel at redhat.com>; Aleksey Shipilev <shade at redhat.com>; hotspot-dev Source Developers <hotspot-dev at openjdk.java.net>
Subject: RE: RFR(T): 8214206: Fix for JDK-8213419 is broken on 32-bit

Hi Roland,

I had already taken http://cr.openjdk.java.net/~roland/8214206/webrev.01/hs.patch when I got the error.

The removal of inline int log2_intptr(intptr_t x) fixes it. I don't see any reason why it should exist.

Best regards,
Martin


-----Original Message-----
From: Roland Westrelin <rwestrel at redhat.com> 
Sent: Donnerstag, 22. November 2018 20:54
To: Doerr, Martin <martin.doerr at sap.com>; Aleksey Shipilev <shade at redhat.com>; hotspot-dev Source Developers <hotspot-dev at openjdk.java.net>
Subject: RE: RFR(T): 8214206: Fix for JDK-8213419 is broken on 32-bit


> please remove log2_intptr(intptr_t x). The sign conversion can be done implicitly.
> This fixes "call of overloaded 'log2_intptr(int)' is ambiguous".

Aleksey's fixes to s390 are not sufficient (see latest webrev)?

Roland.