RFR(T): 8214206: Fix for JDK-8213419 is broken on 32-bit

Tobias Hartmann tobias.hartmann at oracle.com
Mon Nov 26 09:08:42 UTC 2018


Hi Roland,

the test was problem listed in the meantime (JDK-8214276). The fix should therefore remove the test
from that list.

Best regards,
Tobias

On 23.11.18 15:13, Doerr, Martin wrote:
> Ship it.
> 
> Thanks, Martin
> 
> 
> -----Original Message-----
> From: Roland Westrelin <rwestrel at redhat.com> 
> Sent: Freitag, 23. November 2018 14:36
> To: Doerr, Martin <martin.doerr at sap.com>; Doerr, Martin <martin.doerr at sap.com>; Aleksey Shipilev <shade at redhat.com>; hotspot-dev Source Developers <hotspot-dev at openjdk.java.net>
> Subject: RE: RFR(T): 8214206: Fix for JDK-8213419 is broken on 32-bit
> 
> 
> Hi Martin,
> 
>> webrev.02 seems to work. But I still wonder why we should have a version which only casts to unsigned.
> 
> Thanks for giving it a try. Not sure if a signed + an unsigned versions
> are needed. But not relying on implicit casting seems safer.
> 
> webrev.02 passes the submit repo. So unless someone objects I'll push it
> later today (with a fix for the misleading comment that David pointed
> out).
> 
> Roland.
> 


More information about the hotspot-dev mailing list