RFR : [XS] 8214373: adjust usage of ReleaseLongArrayElements in MacosxDebuggerLocal

Thomas Stüfe thomas.stuefe at gmail.com
Tue Nov 27 16:46:38 UTC 2018


Hi Matthias,

looks fine.

How did you find this, via Coverity?

... Thomas

On Tue, Nov 27, 2018 at 4:09 PM Baesken, Matthias
<matthias.baesken at sap.com> wrote:
>
> Hello, please review this small fix .
>
>
>
> In  MacosxDebuggerLocal.m ,  at a few places  the  functions   GetLongArrayElements  and  ReleaseLongArrayElements  are used.
>
>
>
> However  there is one place  where in an early return  the ReleaseLongArrayElements call has been forgotten .
>
>
>
> Additionally at another place  ReleaseLongArrayElements   is at the wrong place (although this is probably not a big issue  currently).
>
>
>
>
>
> Bug/webrev:
>
>
>
> https://bugs.openjdk.java.net/browse/JDK-8214373
>
>
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8214373.0/
>
>
>
>
>
>
>
> Thanks, Matthias


More information about the hotspot-dev mailing list