RFR (S) 8211239: Build fails without JFR: empty JFR events signatures mismatch

[David Holmes]

Hi Aleksey,

On 1/10/2018 5:37 PM, Aleksey Shipilev wrote:
> On 09/28/2018 10:46 PM, Markus Gronlund wrote:
>> I am ok with this from a JFR perspective.
> 
> Thanks!
> 
>> -----Original Message-----
>> From: Aleksey Shipilev <shade at redhat.com>
>> Sent: den 28 september 2018 13:25
>> To: hotspot-dev at openjdk.java.net
>> Subject: RFR (S) 8211239: Build fails without JFR: empty JFR events signatures mismatch
>>
>> Bug:
>>    https://bugs.openjdk.java.net/browse/JDK-8211239
>>
>> Fix:
>>    http://cr.openjdk.java.net/~shade/8211239/webrev.02/
> 
> Any other Reviewers? Would like to unbreak jdk/jdk :)

Isn't printEmptyType redundant with this change?

480             out.write("template <typename T>");

Why is this now a template class? I don't see T being used.

The refactoring to handle the "empty" case within the same logic seems 
reasonable, though it's not immediately obvious to me where the 
signature mismatch was introduced previously or how the refactor 
prevents that ?

Thanks,
David

> -Aleksey
>