RFR : 8211326 : add OS user related information to hs_err file

[Baesken, Matthias]

Hello,  my proposal  would be to  only print

uid : 1679 (testuser-name)

by default  and guard  the rest of the info  by some XX-flag, any good proposals  for the flag-name are appreciated; 
 for example :

if  (ExtendHsErrorFileByUserRelatedInformation)  {

  // print those too :
  
> > > euid : 1679 (testuser-name)
> > > gid : 25 (testgroup)
> > > egid : 25 (testgroup)
> > >
> > > umask: 0022 (removing ----w--w-)

}


Best regards, Matthias


> -----Original Message-----
> From: Baesken, Matthias
> Sent: Dienstag, 2. Oktober 2018 12:38
> To: 'David Holmes' <david.holmes at oracle.com>; 'hotspot-
> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Subject: RE: RFR : 8211326 : add OS user related information to hs_err file
> 
> Hi David,  I think the added info   could be seen more or less in line   with
> what currently is reported in hs_err file .
> For instance you usually see  user-names and lots of paths from the system
> in the hs_err file .
> 
> In case the umask and gid  is  seen as more sensitive than that,  one could
> make  the output switchable with  an XX-flag ;
>  this  would have the  benefit of making the added output more clear to the
> user/admin .
> 
> Best regards, Matthias
> 
> 
> > -----Original Message-----
> > From: David Holmes <david.holmes at oracle.com>
> > Sent: Dienstag, 2. Oktober 2018 09:49
> > To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-
> > dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> > Subject: Re: RFR : 8211326 : add OS user related information to hs_err file
> >
> > Hi Matthias,
> >
> > On 2/10/2018 5:30 PM, Baesken, Matthias wrote:
> > > Hello , please review this small enhancement to the hs_err file .
> > >
> > > Currently the hs_err file contains only limited OS user related
> information.
> > > Just the user name is printed via output of environment variables (at
> least
> > on Windows with USERNAME - output).
> > > The enhanced output on UNIX would contain more information including
> > uid, gid and umask  :
> > >
> > > uid : 1679 (testuser)
> > > euid : 1679 (testuser)
> > > gid : 25 (testgroup)
> > > egid : 25 (testgroup)
> > >
> > > umask: 0022 (removing ----w--w-)
> >
> > Could any of this be considered sensitive information by an end-user?
> >
> > Thanks,
> > David
> >
> > >
> > > (  Some of the info above could be found currently  in error logging
> output
> > e.g.
> > >              attachListener_linux.cpp   line 362
> > >              log_debug(attach)("euid/egid check failed (%d/%d vs %d/%d)",
> > > (and the user name on Windows(-only) is in the env variables section).
> > >
> > >
> > >
> > > bug/webrev :
> > > ----------------------
> > >
> > > https://bugs.openjdk.java.net/browse/JDK-8211326
> > >
> > > http://cr.openjdk.java.net/~mbaesken/webrevs/8211326.0/
> > >
> > >
> > > Thanks, Matthias
> > >