RFR [XS] : hotspot/share/opto/parse2.cpp compile error with gcc 7.3.1

[Baesken, Matthias]

Hello  Severin and  Vladimir ,
I tried a   slowdebug  build  but the expected  error at 

2857     sprintf(buffer, "Bytecode %d: %s", bci(), Bytecodes::name(bc()));

does not show up  .
So it seem the float-output I addressed in my webrev   is  handled in another way than this coding part by gcc .

Should I  still fix this as well and use snprintf  , and post another webrev ?


Best regards, Matthias




> -----Original Message-----
> From: Severin Gehwolf <sgehwolf at redhat.com>
> Sent: Dienstag, 9. Oktober 2018 18:00
> To: Vladimir Kozlov <vladimir.kozlov at oracle.com>; Baesken, Matthias
> <matthias.baesken at sap.com>; 'hotspot-dev at openjdk.java.net' <hotspot-
> dev at openjdk.java.net>
> Subject: Re: RFR [XS] : hotspot/share/opto/parse2.cpp compile error with gcc
> 7.3.1
> 
> On Tue, 2018-10-09 at 08:06 -0700, Vladimir Kozlov wrote:
> > Why there is no complain about sprintf at line 2857 which uses %s? :
> >
> http://hg.openjdk.java.net/jdk/jdk/file/d24b89390f6c/src/hotspot/share/op
> to/parse2.cpp#l2857
> 
> Perhaps because this is non-product code?
> 
> Thanks,
> Severin