RFR [XS] : hotspot/share/opto/parse2.cpp compile error with gcc 7.3.1

[Thomas Stüfe]

Looks fine, Matthias.

Cheers, Thomas
On Wed, Oct 10, 2018 at 5:50 PM Baesken, Matthias
<matthias.baesken at sap.com> wrote:
>
> Hi Thomas / Severin,  I prepared a second webrev , this uses  jio_snprintf  and  adjusts  the other  line  found by Vladimir as well :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8211929.1/
>
>
> > Hence, I'm not surprised you don't see the warning in slowdebug. Have
> > you tried fastdebug?
>
> I have, but do not see a  compiler warning .
>
> Best regards, Matthias
>
>
> > -----Original Message-----
> > From: Severin Gehwolf <sgehwolf at redhat.com>
> > Sent: Mittwoch, 10. Oktober 2018 14:47
> > To: Baesken, Matthias <matthias.baesken at sap.com>; Vladimir Kozlov
> > <vladimir.kozlov at oracle.com>; 'hotspot-dev at openjdk.java.net' <hotspot-
> > dev at openjdk.java.net>
> > Subject: Re: RFR [XS] : hotspot/share/opto/parse2.cpp compile error with gcc
> > 7.3.1
> >
> > Hi Matthias,
> >
> > On Wed, 2018-10-10 at 12:36 +0000, Baesken, Matthias wrote:
> > > Hello  Severin and  Vladimir ,
> > > I tried a   slowdebug  build  but the expected  error at
> > >
> > > 2857     sprintf(buffer, "Bytecode %d: %s", bci(), Bytecodes::name(bc()));
> > >
> > > does not show up  .
> > > So it seem the float-output I addressed in my webrev   is  handled in
> > another way than this coding part by gcc .
> > >
> > > Should I  still fix this as well and use snprintf  , and post another webrev ?
> >
> > That matches what I've seen with JDK-8210647. The optimization level
> > matters for warnings to get produced. libsaproc was previously compiled
> > with -O0 and post-change, JDK-8210836 happened. The reporter had gcc
> > 7.3.0. Apparently it wasn't an issue prior JDK-8210647 when no
> > optimization was being used.
> >
> > Hence, I'm not surprised you don't see the warning in slowdebug. Have
> > you tried fastdebug?
> >
> > I'll leave it to Vladimir to decide whether he wants it changed or not.
> >
> > Thanks,
> > Severin
> >
> > > Best regards, Matthias
> > >
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Severin Gehwolf <sgehwolf at redhat.com>
> > > > Sent: Dienstag, 9. Oktober 2018 18:00
> > > > To: Vladimir Kozlov <vladimir.kozlov at oracle.com>; Baesken, Matthias
> > > > <matthias.baesken at sap.com>; 'hotspot-dev at openjdk.java.net'
> > <hotspot-
> > > > dev at openjdk.java.net>
> > > > Subject: Re: RFR [XS] : hotspot/share/opto/parse2.cpp compile error with
> > gcc
> > > > 7.3.1
> > > >
> > > > On Tue, 2018-10-09 at 08:06 -0700, Vladimir Kozlov wrote:
> > > > > Why there is no complain about sprintf at line 2857 which uses %s? :
> > > > >
> > > >
> > > >
> > http://hg.openjdk.java.net/jdk/jdk/file/d24b89390f6c/src/hotspot/share/op
> > > > to/parse2.cpp#l2857
> > > >
> > > > Perhaps because this is non-product code?
> > > >
> > > > Thanks,
> > > > Severin
> > >
> > >
>