RFR : 8211089: windows : print process heaps information in hs_err file

[Langer, Christoph]

Hi Matthias,

I think this information is category "nice to have". It should probably guarded by the new option that is proposed by Thomas' CSR draft: https://bugs.openjdk.java.net/browse/JDK-8211846.

The implementation looks ok to me.

Best regards
Christoph

> -----Original Message-----
> From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of
> Baesken, Matthias
> Sent: Freitag, 28. September 2018 09:41
> To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Subject: RE: RFR : 8211089: windows : print process heaps information in
> hs_err file
> 
>  Ping ....
> 
> Would be great to have some reviews on this !
> 
> Thanks, Matthias
> 
> > -----Original Message-----
> > From: Baesken, Matthias
> > Sent: Dienstag, 25. September 2018 15:53
> > To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> > Subject: RFR : 8211089: windows : print process heaps information in hs_err
> > file
> >
> > Hello , please review this small change.
> > It adds output of information regarding Windows process heaps (see
> > https://docs.microsoft.com/en-us/windows/desktop/api/heapapi/nf-
> > heapapi-getprocessheaps )
> > to the hs_error file.
> > we had this for some time in our internal JVM and want to bring it to
> > OpenJDK as well.
> > It is a Windows-only extension.
> >
> > bug :   8211089: windows : print process heaps information in hs_err file
> > https://bugs.openjdk.java.net/browse/JDK-8211089
> >
> >
> > webrev :
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8211089.0/
> >
> >
> >
> > extended output is usually small, and looks like this :
> >
> >
> > ---------------  S Y S T E M  ---------------
> >
> > OS: Windows 10 , 64 bit Build ......
> >
> > ....
> >
> > 4 Process Heaps:
> >   Heap ID: 1 0x00000186491a0000  default crt  low-fragmentation
> >   Heap ID: 2 0x0000018649000000                      standard
> >   Heap ID: 3 0x0000018649430000                      low-fragmentation
> >   Heap ID: 4 0x000001864adb0000                      low-fragmentation
> >
> >
> > Thanks, Matthias